Skip to content

Commit

Permalink
Shortcodes: Improve handling from shortcode_parse_attts().
Browse files Browse the repository at this point in the history
Added missing @ticket for #47863 on `data_shortcode_parse_atts()`

Also cleans up some linter fixes that were missed.

Props garrett-eclipse, whyisjake.
ixes #47863.


git-svn-id: https://develop.svn.wordpress.org/trunk@46370 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
whyisjake committed Oct 1, 2019
1 parent 1f5525d commit 02cf7f5
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions tests/phpunit/tests/shortcode.php
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -740,7 +740,7 @@ function test_pcre_performance( $input ) {
} }


function data_whole_posts() { function data_whole_posts() {
require_once( DIR_TESTDATA . '/formatting/whole-posts.php' ); require_once DIR_TESTDATA . '/formatting/whole-posts.php';
return data_whole_posts(); return data_whole_posts();
} }


Expand Down Expand Up @@ -992,6 +992,8 @@ public function test_shortcode_parse_atts( $text, $expected ) {
/** /**
* Data provider for `test_shortcode_parse_atts()`. * Data provider for `test_shortcode_parse_atts()`.
* *
* @ticket 47863
*
* @return array { * @return array {
* @type array { * @type array {
* @type string $text A single shortcode format or key/value pair string. * @type string $text A single shortcode format or key/value pair string.
Expand Down Expand Up @@ -1057,19 +1059,19 @@ public function data_shortcode_parse_atts() {
array( array(
'[unittest link=https://unit.test/ /]', '[unittest link=https://unit.test/ /]',
array( array(
'link' => 'https://unit.test/', 'link' => 'https://unit.test/',
), ),
), ),
array( array(
'[unittest link=https://unit.test/ ]', '[unittest link=https://unit.test/ ]',
array( array(
'link' => 'https://unit.test/', 'link' => 'https://unit.test/',
), ),
), ),
array( array(
'[unittest link=https://unit.test/]', '[unittest link=https://unit.test/]',
array( array(
'link' => 'https://unit.test', 'link' => 'https://unit.test',
), ),
), ),
array( array(
Expand Down

0 comments on commit 02cf7f5

Please sign in to comment.