Coding Standards: Switch WordPress.PHP.YodaConditions.NotYoda back …

…to error level.

This was marked as a warning in [45665] until all the issues associated with the sniff are addressed, so that linting on Travis could run across the entire codebase.

With all the instances now addressed, this override is no longer needed.

Follow-up to [47054], [47218], [47219].

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47551 602fd350-edb4-49c9-b593-d223f7449a82

phpcs.xml.dist

@@ -29,9 +29,6 @@
 	<rule ref="WordPress.CodeAnalysis.EmptyStatement"/>
 
 	<!-- These rules are being set as warnings instead of errors, so we can error check the entire codebase. -->
-	<rule ref="WordPress.PHP.YodaConditions.NotYoda">
-		<type>warning</type>
-	</rule>
 	<rule ref="WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase">
 		<type>warning</type>
 	</rule>