Skip to content

Commit

Permalink
Coding Standards: Break the $path reference after a foreach loop …
Browse files Browse the repository at this point in the history
…in `block_editor_rest_api_preload()`.

When using a `foreach` loop with a value assigned by reference, the variable continues to point to the last array element even after the loop, so it is recommended to destroy it by `unset()` to avoid unexpected behavior later on.

See [https://www.php.net/manual/en/control-structures.foreach.php PHP Manual: foreach].

Follow-up to [52312], [52313].

Props TobiasBg.
See #54558.

git-svn-id: https://develop.svn.wordpress.org/trunk@52322 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
SergeyBiryukov committed Dec 4, 2021
1 parent 4eee810 commit 76357a2
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/wp-includes/block-editor.php
Expand Up @@ -83,6 +83,7 @@ function get_block_categories( $post_or_block_editor_context ) {
* @param WP_Block_Editor_Context $block_editor_context The current block editor context.
*/
$block_categories = apply_filters( 'block_categories_all', $block_categories, $block_editor_context );

if ( ! empty( $block_editor_context->post ) ) {
$post = $block_editor_context->post;

Expand Down Expand Up @@ -123,6 +124,7 @@ function get_allowed_block_types( $block_editor_context ) {
* @param WP_Block_Editor_Context $block_editor_context The current block editor context.
*/
$allowed_block_types = apply_filters( 'allowed_block_types_all', $allowed_block_types, $block_editor_context );

if ( ! empty( $block_editor_context->post ) ) {
$post = $block_editor_context->post;

Expand Down Expand Up @@ -397,6 +399,7 @@ function get_block_editor_settings( array $custom_settings, $block_editor_contex
* @param WP_Block_Editor_Context $block_editor_context The current block editor context.
*/
$editor_settings = apply_filters( 'block_editor_settings_all', $editor_settings, $block_editor_context );

if ( ! empty( $block_editor_context->post ) ) {
$post = $block_editor_context->post;

Expand Down Expand Up @@ -440,6 +443,7 @@ function block_editor_rest_api_preload( array $preload_paths, $block_editor_cont
* @param WP_Block_Editor_Context $block_editor_context The current block editor context.
*/
$preload_paths = apply_filters( 'block_editor_rest_api_preload_paths', $preload_paths, $block_editor_context );

if ( ! empty( $block_editor_context->post ) ) {
$selected_post = $block_editor_context->post;

Expand Down Expand Up @@ -479,6 +483,8 @@ function block_editor_rest_api_preload( array $preload_paths, $block_editor_cont
}
}

unset( $path );

$preload_data = array_reduce(
$preload_paths,
'rest_preload_api_request',
Expand Down

0 comments on commit 76357a2

Please sign in to comment.