Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API: Inconsistent parameter type handling in set_param() #181

Closed
wants to merge 6 commits into from

Conversation

mnelson4
Copy link

@mnelson4 mnelson4 commented Mar 7, 2020

Trac ticket: https://core.trac.wordpress.org/ticket/40838


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@mnelson4 mnelson4 changed the title created branch from vagios 40838.1.patch REST API: Inconsistent parameter type handling in set_param() Mar 7, 2020
Copy link
Member

@TimothyBJacobs TimothyBJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! Some minor changes. Let's also add a test with a null parameter.

src/wp-includes/rest-api/class-wp-rest-request.php Outdated Show resolved Hide resolved
tests/phpunit/tests/rest-api/rest-request.php Show resolved Hide resolved
tests/phpunit/tests/rest-api/rest-request.php Show resolved Hide resolved
@kadamwhite
Copy link
Contributor

Committed in changeset 47559, thank you @mnelson4

@kadamwhite kadamwhite closed this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants