New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About page for 5.9, first pass #2106
Conversation
Looks great, thank you for making the headings a bit smaller 👍 |
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
"refactor" is a verb. The corresponding noun would be "refactoring". |
Thanks for reporting that — since that's a CSS issue, we can work on that post-RC1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryelle LGTM! I think it's ready for commit 👍
Committed in r52438 |
Getting a PR up for the About page. I thought the copy was stable as of 12/20, so that's what this uses, but there's still discussion ongoing today so I'll swing back through and update it once that's finalized. (In the future, the copy should be final before/in tandem with design, ideally before beta).
I still need to drop in the other pages' header assets, and figure out what to do about column sizing. In this PR, I've tweaked the size of the "wider 2-column" layout to be two-fifths/three-fifths, which fits the (older?) copy & images better. Whatever is decided about the sizing, I can make that change (cc @critterverse).
Desktop [1250px wide]
Tablet [750px wide]
Phone [480px wide]
Trac ticket: https://core.trac.wordpress.org/ticket/54270
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.