Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About page for 5.9, first pass #2106

Closed
wants to merge 9 commits into from
Closed

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Jan 3, 2022

Getting a PR up for the About page. I thought the copy was stable as of 12/20, so that's what this uses, but there's still discussion ongoing today so I'll swing back through and update it once that's finalized. (In the future, the copy should be final before/in tandem with design, ideally before beta).

I still need to drop in the other pages' header assets, and figure out what to do about column sizing. In this PR, I've tweaked the size of the "wider 2-column" layout to be two-fifths/three-fifths, which fits the (older?) copy & images better. Whatever is decided about the sizing, I can make that change (cc @critterverse).

Desktop [1250px wide]

Tablet [750px wide]

Phone [480px wide]


Trac ticket: https://core.trac.wordpress.org/ticket/54270


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ryelle ryelle self-assigned this Jan 3, 2022
@ryelle
Copy link
Contributor Author

ryelle commented Jan 3, 2022

Now with updated headers, including the shorter header text on Freedoms.

about

credits

freedoms

privacy

@audrasjb
Copy link
Contributor

audrasjb commented Jan 3, 2022

Looks great, thank you for making the headings a bit smaller 👍

@ryelle
Copy link
Contributor Author

ryelle commented Jan 4, 2022

Updated "Navigation block" section:
Screen Shot 2022-01-04 at 10 06 37 AM

Updated "Paintbox" sections:
Screen Shot 2022-01-04 at 10 06 26 AM

Updated developer note — I changed the theme.json section to "Introducing Block Themes" (should that be sentence case?) and copied/tweaked some content from the dev note for the section itself.
Screen Shot 2022-01-04 at 10 06 46 AM

src/wp-admin/about.php Show resolved Hide resolved
src/wp-admin/about.php Outdated Show resolved Hide resolved
src/wp-admin/about.php Show resolved Hide resolved
src/wp-admin/about.php Show resolved Hide resolved
src/wp-admin/about.php Show resolved Hide resolved
src/wp-admin/about.php Outdated Show resolved Hide resolved
src/wp-admin/about.php Outdated Show resolved Hide resolved
ryelle and others added 2 commits January 4, 2022 11:57
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
src/wp-admin/css/about.css Outdated Show resolved Hide resolved
@walbo
Copy link
Member

walbo commented Jan 4, 2022

Looks great! 👍 Found a small regression on the freedoms page. The PR removes the gap between the rows.

image

And on "tablet" the first column isn't aligned correctly.

image

@tobifjellner
Copy link

"refactor" is a verb. The corresponding noun would be "refactoring".
Therefore "a near-complete refactor" should be "a near-complete refactoring".

@ryelle
Copy link
Contributor Author

ryelle commented Jan 4, 2022

The PR removes the gap between the rows.

Thanks for reporting that — since that's a CSS issue, we can work on that post-RC1.

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryelle LGTM! I think it's ready for commit 👍

@ryelle
Copy link
Contributor Author

ryelle commented Jan 4, 2022

Committed in r52438

@ryelle ryelle closed this Jan 4, 2022
@ryelle ryelle deleted the about-59 branch January 4, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants