Malformed sticky_posts option breaks sticky posts. #2353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@costdev Would you be able to take a look at this PR, for some reason I can not assign you as a reviewer. |
costdev
requested changes
Apr 21, 2022
tests/phpunit/tests/post.php
Outdated
Comment on lines
1720
to
1726
| * Data provider for test_stick_post_after_delete_sticky_posts_option(). | ||
| * | ||
| * @return array[] { | ||
| * Arguments passed to test. | ||
| * | ||
| * @type mixed $stick Value to pass to stick_post(). | ||
| * } |
There was a problem hiding this comment.
Data provider docblocks can be simply this:
/**
* Data provider.
*
* @return array
*/This reduces maintainence churn for arguments, as well as when future test methods may also use the data provider.
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
|
Committed in https://core.trac.wordpress.org/changeset/53238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://core.trac.wordpress.org/ticket/55176