New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate PHP packages in the sync-gutenberg-packages task #2679
Regenerate PHP packages in the sync-gutenberg-packages task #2679
Conversation
…the build task before build:dev
848ba38
to
6156242
Compare
Gruntfile.js
Outdated
* https://core.trac.wordpress.org/ticket/55559 | ||
*/ | ||
const distTag = grunt.option('dist-tag') || 'latest'; | ||
const currentBranch = spawn( 'git', [ 'branch', '--show-current' ], { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't work for svn users 😅
However, I think it's very unlikely you would run latest
outside of the trunk
branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not block this PR on that and move this discussion to a separate one
Fantastic! Let's close this PR then |
What problem does this PR solve?
The
npx sync-gutenberg-packages
command introduced in #2621 does not regenerate thescript-loader-packages.php
file.This PR makes it run
npm run build
to regenerate that file.Let's test it on Tuesday when releasing RC2 @gziolo