Implement new timeout/duration/expiration format. #3047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the value can be represented as an integer (not a fractional) number of minutes (hours, etc.), use the appropriate constant multiplied by that number. Otherwise, keep the value as is and add a comment with the units for clarity.
costdev
commented
Aug 1, 2022
| @@ -1597,7 +1597,7 @@ public static function get_sizes() { | |||
| // The max_execution_time defaults to 0 when PHP runs from cli. | |||
| // We still want to limit it below. | |||
| if ( empty( $max_execution_time ) ) { | |||
| $max_execution_time = 30; | |||
| $max_execution_time = 30; // 30 seconds. | |||
| } | |||
|
|
|||
| if ( $max_execution_time > 20 ) { | |||
There was a problem hiding this comment.
I didn't touch this line because the comment below explains the units.
However, this condition tests to see if the max_execution_time is greater than 20, but the comment states:
If the max_execution time is set to lower than 20 seconds.
The comment should be changed to reflect what the condition actually checks:
/*
* If the max_execution_time is set to more than 20 seconds, reduce it a bit to prevent
* edge-case timeouts that may happen after the size loop has finished running.
*/Also note that the current comment does not follow the correct multi-line comment format per Documentation Standards. The edited comment above does.
rudlinkon
approved these changes
Aug 1, 2022
|
Committed in https://core.trac.wordpress.org/changeset/54113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/56293