Add plugin urls to auto update emails. #3100
Conversation
costdev
force-pushed
the
add_plugin_urls_to_auto_update_emails
branch
3 times, most recently
from
167e396
to
2999b8d
Compare
| $has_successful = ! empty( $successful ); | ||
| $has_failed = ! empty( $failed ); | ||
|
|
||
| if ( ! $has_successful && ! $has_failed ) { | ||
| $this->markTestSkipped( 'This test requires at least one successful or failed plugin update object.' ); | ||
| } | ||
|
|
||
| $type = $has_successful && $has_failed ? 'mixed' : ( ! $has_failed ? 'success' : 'fail' ); |
There was a problem hiding this comment.
This isn't strictly necessary and could be replaced with a $type argument in each dataset.
I included this in the tests to:
- let contributors focus on testing the update objects.
- reduce the size of the datasets.
- reduce the potential for human error by failing to note the correct
$typewhen copying/pasting datasets.
costdev
force-pushed
the
add_plugin_urls_to_auto_update_emails
branch
from
2999b8d
to
05db467
Compare
| __( '- %1$s (from version %2$s to %3$s)' ), | ||
| $body_message .= sprintf( | ||
| /* translators: 1: Plugin name, 2: Current version number, 3: New version number, 4: Plugin URL. */ | ||
| __( '- %1$s (from version %2$s to %3$s)%4$s' ), |
There was a problem hiding this comment.
| __( '- %1$s (from version %2$s to %3$s)%4$s' ), | |
| __( '- %1$s (from version %2$s to %3$s) %4$s' ), |
🔢 This applies to others, they'll need a space too.
There was a problem hiding this comment.
The space is included in $item_url:
$item_url = ' : ' . esc_url( $item->item->url );Otherwise, with an empty $item_url, there would be a trailing space.
There was a problem hiding this comment.
Thanks.
I think this might be problematic for i18n as it assumes the sentence works with : http://example.com/colins-plugin and I don't think that's reliably the case.
Unfortunately this involves doubling the number of strings again so I'll defer to people who know much better than I for confirmation. @SergeyBiryukov @audrasjb do you have thoughts here?
costdev
force-pushed
the
add_plugin_urls_to_auto_update_emails
branch
from
e8ea3e4
to
e33ac48
Compare
This method is used more widely in the test suite.
|
Merged into core in https://core.trac.wordpress.org/changeset/54212. |
This PR refreshes #1688 with changes requested by @peterwilsoncc and adds PHPUnit tests.
Trac ticket: https://core.trac.wordpress.org/ticket/53049