TT2: Make Post Comments block headlines H2s #3150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
src/wp-content/themes/twentytwentytwo/comments.phpfile that will be picked up by the Post Comments block to render, well, a post's comments. The file is copied from Core'stheme-compat/comments.php, with some modifications to change the H3 headings ("One reply to..." and "Leave a reply") to H2, in order to address this a11y issue.Note that this issue has been discussed in both WordPress/gutenberg#43203 and #3136. I currently believe that this PR is both necessary and sufficient, so it could be deemed a complete solution. (As @Carolina pointed out, it's unfortunate that we have to add a PHP file to customize a block theme, but I currently don't see any alternative.)
Trac ticket: https://core.trac.wordpress.org/ticket/55172
Testing instructions
Using the TT2 theme, view a single post with comments on the frontend (e.g. the "Hello World" post that comes with a new WP install. Verify that both the "One reply to..." and "Leave a reply" headings are H2.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.