Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 56799 #3442

Closed
wants to merge 2 commits into from
Closed

Ticket 56799 #3442

wants to merge 2 commits into from

Conversation

petitphp
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/56799


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Able to reproduce the PHP notice
  • Confirmed this PR fixes it
  • Moved the code to after the guard clause for a tiny micro-optimization
  • Reformatted for readability

Ready for commit 👍

Copy link
Member

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the issue.

@hellofromtonya
Copy link
Contributor

Committed via changeset https://core.trac.wordpress.org/changeset/54498. Thank you @petitphp for your contribution!

@petitphp petitphp deleted the ticket/56799 branch October 11, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants