Canonical: Validate NOT EXISTS tax_query does not error #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in canonical redirect code
kadamwhite
force-pushed
the
55955-not-exists-tax-query-canonical-error
branch
from
ff49093
to
8546e08
Compare
costdev
requested changes
Nov 4, 2022
peterwilsoncc
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
LGTM.
tests fail without the changes to src, see https://github.com/WordPress/wordpress-develop/pull/3596/checks
|
@MiguelAxcarHM are you able to link your WordPress.org account to your GitHub account so I can ensure you are given props correctly? This can be done in the GitHub username section of https://profiles.wordpress.org/me/profile/edit/group/1/ Edit: I found Kadam's mention of you in the ticket so gave you props on this but linking your account will help for future contributions. |
|
Done @peterwilsoncc , thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in 55955, a NOT EXISTS tax_query causes a warning (PHP <= 7.4) or an error (PHP >= 8.0) in the
redirect_canonicalfunction because there is acount( $tax_query['terms'] )check in that function that does not verify whether thetermsproperty is present. It will not be present in NOT EXISTS queries because there is no purpose in specifying individual terms when we are querying for posts which have no terms at all.Trac ticket: https://core.trac.wordpress.org/ticket/55955
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.