Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "Full site editing" with "Site Editor" #3578

Closed
wants to merge 1 commit into from
Closed

Replace "Full site editing" with "Site Editor" #3578

wants to merge 1 commit into from

Conversation

audrasjb
Copy link
Contributor

@audrasjb audrasjb commented Nov 7, 2022

peterwilsoncc
peterwilsoncc approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches what I see searching for site edit, full site and \bfse\b (regex).

@carolinan
Copy link

Looks good to me.

-For the theme tag it would be good to create an alias and not only change the label, so that theme developers can use the shorter term.
This also needs to be updated in the api.

krupal-panchal
krupal-panchal approved these changes Nov 10, 2022
View reviewed changes
Copy link

@krupal-panchal krupal-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@audrasjb
Copy link
Contributor Author

Good point @carolinan :)
Let's commit this change first so it's ready to ship with 6.1.1 if it's possible.
Then I'll open a Meta Trac ticket to ask for a change in WordPress.org, then we can open a new ticket to change the tag accordingly :)

@audrasjb
Copy link
Contributor Author

Committed in https://core.trac.wordpress.org/changeset/54786

@audrasjb audrasjb closed this Nov 10, 2022
@audrasjb audrasjb deleted the 57026 branch November 10, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

@krupal-panchal krupal-panchal krupal-panchal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@audrasjb @carolinan @peterwilsoncc @krupal-panchal