wp_nav_menu() throws undefined offset if a menu item's parent has a higher ID.

[peterwilsoncc]

Just some tests initially.

https://core.trac.wordpress.org/ticket/57122

[costdev]

Just to confirm, the parent of self::$lvl1_menu_item does not need to be reset to self::$lvl0_menu_item as the parent set_up()/tear_down() methods handle resetting this. Is that correct?

All other tests pass if you move this new test to the top of the file, and this drop-in test method also passes:

public function test_that_peter_did_not_break_the_test_suite() {
	$menu_items = wp_get_nav_menu_items( self::$menu_id );
	$this->assertSame( (int) $menu_items[1]->menu_item_parent, self::$lvl0_menu_item );
}

But just asking to be sure.

[peterwilsoncc]

Just to confirm, the parent of self::$lvl1_menu_item does not need to be reset to self::$lvl0_menu_item as the parent set_up()/tear_down() methods handle resetting this. Is that correct?

Yes, that is correct.

Changes to the post and post meta table are stored in a transaction that is started in the test suite's setup and rolled back during the tear-down.

wordpress-develop/tests/phpunit/includes/abstract-testcase.php

Lines 136 to 146 in 389a78e

	$this->start_transaction();
	$this->expectDeprecated();
	add_filter( 'wp_die_handler', array( $this, 'get_wp_die_handler' ) );
	}
	/**
	* After a test method runs, resets any state in WordPress the test method might have changed.
	*/
	public function tear_down() {
	global $wpdb, $wp_query, $wp;
	$wpdb->query( 'ROLLBACK' );

[peterwilsoncc]

Committed in c98ca19 / r55328