Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove title attributes from bundled themes #3681

Closed

Conversation

sabernhardt
Copy link

@sabernhardt sabernhardt commented Nov 24, 2022

This starts with the most straightforward problems:

  1. Removes 13 redundant title attributes.
  2. Adds accessible text to the Showcase template links. The title attribute remains, silenced with aria-hidden, with a style change so it still covers the full link area.

Trac ticket: https://core.trac.wordpress.org/ticket/57199


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

- Skip to content
- Site name
- Author name in author archive heading link
- Comment timestamp links
Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sabernhardt LGTM 🚀

@audrasjb
Copy link
Contributor

audrasjb commented Dec 1, 2022

PR fully committed, see the related ticket.

@audrasjb audrasjb closed this Dec 1, 2022
@sabernhardt sabernhardt deleted the bundled-themes-title-attribute branch April 7, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants