Port Edit Image endpoint #388
Conversation
|
|
||
| // This also confirms the attachment is an image. | ||
| $image_file = wp_get_original_image_path( $attachment_id ); | ||
| $image_meta = wp_get_attachment_metadata( $attachment_id ); |
There was a problem hiding this comment.
There is a possible rare edge case here: the attachment_id comes from the image block (hard-coded in post_content), but if the site was moved, i.e. posts have been exported and imported at another site, the post IDs may change. Seems this will also need to confirm that $image_meta is for the same image. (Not in scope here, just need to remember to add it).
src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php
Outdated
Show resolved
Hide resolved
|
Looks good, just one small nitpick :) Will also need to verify that |
| return array( | ||
| 'rotation' => array( | ||
| 'description' => __( 'The amount to rotate the image clockwise in degrees.' ), | ||
| 'type' => 'integer', |
There was a problem hiding this comment.
@ajlende can this be constrained to a min 0 and max 360?
There was a problem hiding this comment.
For this version, yes, that's fine. In the next, I'd prefer to not have constraints on it. It's easy enough to convert to the correct range, but if you're rotating 270 degrees, for example, it might be more natural to say -90 instead. I'd assume the implementations for rotating an image in WP_Image_Editor take this into account, so converting to a specific range just seems like an extra step.
|
Should we be checking against |
Possibly, but seems better to let the user edit the image, and decide if they should delete the parent image? Users can get over the quota even when uploading a large image that creates many sub-sizes... Would make sense to return a "non-blocking" error that the user in now over the quota after saving the edited image :) |
Gotcha. I'll leave it alone for now then. This works for me testing against the latest Gutenberg. It still doesn't work alone on trunk since the JS in trunk is still expecting the old endpoint. |
Porting the edit image endpoint from Gutenberg.
This is a WIP, working on adding tests. One question I had was the descriptions of the request args, I did my best to add them based on my understanding of how the endpoint works, but that might not be accurate.
Cc: @ajlende.
Trac ticket: https://core.trac.wordpress.org/ticket/44405
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.