Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct variable name for the new feature declaration #3907

Closed

Conversation

Mamaduka
Copy link
Member

PR fixes a small regression after 54805, where an incorrect variable was used inside the loop.

Trac ticket: https://core.trac.wordpress.org/ticket/57067


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @Mamaduka!

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @Mamaduka!

@felixarntz
Copy link
Member

Committed in https://core.trac.wordpress.org/changeset/55142.

@felixarntz felixarntz closed this Jan 25, 2023
@Mamaduka Mamaduka deleted the fix/theme-json-undefined-var branch May 9, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants