Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_block_templates: remove the theme parameter from the query #4086

Closed
wants to merge 1 commit into from
Closed

get_block_templates: remove the theme parameter from the query #4086

wants to merge 1 commit into from

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Feb 16, 2023

Trac ticket https://core.trac.wordpress.org/ticket/57736

This PR removes the theme parameter from the query passed to get_block_templates. It is not used or documented. This removal doesn't have any effect in the code, as the data is ignored anyway.

Copy link

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I performed a quick search and it appears that no known plugin use this parameter. Which sounds logical as it was never documented anywhre, but worth checking.

marking this as ready for commit.

@oandregal
Copy link
Member Author

This has been committed at https://core.trac.wordpress.org/changeset/55686

@oandregal oandregal closed this Apr 26, 2023
@oandregal oandregal deleted the update/remove-unused-parameter branch April 26, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants