Fix all posts showing when no posts are sticky #4144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue where all non-sticky posts show up in the Query Loop block when Sticky Posts is set to "Only" and there are no sticky posts. Additional `(array)` typecast for safety. See https://core.trac.wordpress.org/ticket/57822
|
We probably should add a test for this for the query loop block |
ocean90
reviewed
Mar 1, 2023
ntsekouras
reviewed
Mar 1, 2023
Co-authored-by: Dominik Schilling <dominikschilling+git@gmail.com>
|
Commits 526d9b1 and 2164f1f bring full parity with the changes in Gutenberg https://github.com/WordPress/gutenberg/blob/42dad571eac32c41a7ff34f0da80fcc4e5ceb3bd/lib/compat/wordpress-6.1/blocks.php#L171-L183 to synchronize Core and Gutenberg. |
|
Just for reference, the function will be under So some links for GB in comments would be different. |
hellofromtonya
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
- Confirmed the changes match the changes in Gutenberg ✅
- Test Report confirms this PR fixes the reported issue ✅
Ready for commit 👍
|
Committed via https://core.trac.wordpress.org/changeset/55447. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where all non-sticky posts show up in the Query Loop block when Sticky Posts is set to "Only" and there are no sticky posts.
Additional
(array)typecast for safety.See https://core.trac.wordpress.org/ticket/57822
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.