Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar improvement after signup. #4314

Closed
wants to merge 4 commits into from
Closed

Conversation

NekoJonez
Copy link

Like I said in the trac ticket, I think the sentence flows a bit better now. I also adjusted the translator comment for make it even more clear.

Trac ticket: (https://core.trac.wordpress.org/ticket/58115)


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added one small change request ;)

src/wp-signup.php Outdated Show resolved Hide resolved
@NekoJonez
Copy link
Author

@audrasjb Fixed! Thanks for that feedback :D

@NekoJonez
Copy link
Author

@audrasjb I looked further and I found the exact same thing lower in the file... So, I fixed that as well.

Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@audrasjb
Copy link
Contributor

audrasjb commented Jun 9, 2023

@audrasjb audrasjb closed this Jun 9, 2023
@NekoJonez NekoJonez deleted the patch-8 branch June 10, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants