58094 8.1 CSV files #4370
58094 8.1 CSV files #4370
Conversation
|
Hi @elenachavdarova! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
| @@ -3181,7 +3181,7 @@ function wp_check_filetype_and_ext( $file, $filename, $mimes = null ) { | |||
| $type = false; | |||
| $ext = false; | |||
| } | |||
| } elseif ( 'application/csv' === $real_mime ) { | |||
| } elseif ( ( 'application/csv' === $real_mime ) || ( 'text/csv' === $real_mime ) ) { | |||
There was a problem hiding this comment.
| } elseif ( ( 'application/csv' === $real_mime ) || ( 'text/csv' === $real_mime ) ) { | |
| } elseif ( 'application/csv' === $real_mime || 'text/csv' === $real_mime ) { |
IMO, it looks a little cleaner to remove the additional parentheses here.
There was a problem hiding this comment.
Thanks for the PR @elenachavdarova! I've just left one thought below regarding parentheses, but this is not a blocker for this PR. 🙂
|
Thanks for the PR! Closing this for now, as the related issue cannot be reproduced, see comment 9 on #58094. |
Include text/csv to the list of supported types in wp_check_filetype_and_ext().
Track ticket: https://core.trac.wordpress.org/ticket/58094