Return empty array when not using themes

[danielbachhuber]

Returns an empty array from wp_get_active_and_valid_themes() when ! wp_using_themes(). The empty array prevents wp-content/themes/functions.php from being loaded erroneously.

See https://core.trac.wordpress.org/ticket/57928

[danielbachhuber]

Seems like a hacky test failure...

[spacedmonkey]

@danielbachhuber Would STYLESHEETPATH be empty in this context?

[danielbachhuber]

@spacedmonkey Unfortunately not. It's set to an erroneous value:

diff --git a/src/wp-includes/load.php b/src/wp-includes/load.php
index 9780519856..bc0a35ab0e 100644
--- a/src/wp-includes/load.php
+++ b/src/wp-includes/load.php
@@ -948,6 +948,9 @@ function wp_get_active_and_valid_themes() {
 		return $themes;
 	}
 
+	var_dump( 'TEMPLATEPATH: ' . TEMPLATEPATH );
+	var_dump( 'STYLESHEETPATH: ' . STYLESHEETPATH );
+
 	if ( ! wp_using_themes() ) {
 		return $themes;
 	}

$ wp --skip-themes option get home
string(82) "TEMPLATEPATH: /Users/danielbachhuber/projects/wordpress-develop/wp-content/themes/"
string(84) "STYLESHEETPATH: /Users/danielbachhuber/projects/wordpress-develop/wp-content/themes/"
https://wordpress-develop.test

Notice the value is /wordpress-develop/wp-content/themes/ without a theme slug.

[spacedmonkey]

Some unit tests for this would be useful to understand what this change means.

[danielbachhuber]

Some unit tests for this would be useful to understand what this change means.

Added a test case in 35091f8

wp_get_active_and_valid_themes() is only used here:

wordpress-develop/src/wp-settings.php

Lines 587 to 593 in 35091f8

	// Load the functions for the active theme, for both parent and child theme if applicable.
	foreach ( wp_get_active_and_valid_themes() as $theme ) {
	if ( file_exists( $theme . '/functions.php' ) ) {
	include $theme . '/functions.php';
	}
	}
	unset( $theme );

Interestingly, the random test failures in my first commit were caused by WP_USE_THEMES being undefined. Apparently that hasn't ever bit anyone before.

WP_USE_THEMES is defined in src/index.php and originates from https://core.trac.wordpress.org/changeset/2303. The test suite doesn't load src/index.php, so the constant wasn't ever defined.

[danielbachhuber]

Shipped with https://core.trac.wordpress.org/changeset/55890