Bookmark Administration on edit_link function in extra remove ( ['lin… #4416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have checked in edit_link function on wp-admin/includes/bookmark.php
And if I look at the code there are add an extra esc_html function to sanitize the ( $_POSTlink_url? ).
After reviewing the example provided for the add_link action, it appears that there is no need to include an esc_html function when handling the ( $_POSTlink_url? ) parameter.
Can you please check my patch and share your feedback.
EDITED by @audrasjb to add a link to the Trac ticket
Trac Ticket: https://core.trac.wordpress.org/ticket/58239