New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
56699 twentytwelve #4642
base: trunk
Are you sure you want to change the base?
56699 twentytwelve #4642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes items that need to remain: the ie.css
file, the twentytwelve-ie
handle, an html
tag, and the credit for the HTML5 Shiv (which is still included in the package).
- Restore the html tag deleted by mistake - Restore the credits - Restore the deleted file
- Restore the html tag deleted by mistake - Restore the credits - Restore the deleted file
Thanks for the feedback @sabernhardt ! Applied the notes and changes, can you take a look is there anything else? if not, I'll open a new PR for the other themes, following the ticket updates. Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you changed "Load" to "Register" in another PR, keeping a verb. Similarly, Twenty Twelve should have "Registers" for its IE stylesheet.
Removing IE specific checks from Twenty Twelve default theme. Keeping the
js/html5.js
as per the note from this commentWorking with @Neychok on the ticket, so we can split the work on the default themes.
Trac ticket: 56699