Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

56699 twentytwelve #4642

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Conversation

metodiew
Copy link

Removing IE specific checks from Twenty Twelve default theme. Keeping the js/html5.js as per the note from this comment

Working with @Neychok on the ticket, so we can split the work on the default themes.

Trac ticket: 56699

Copy link

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes items that need to remain: the ie.css file, the twentytwelve-ie handle, an html tag, and the credit for the HTML5 Shiv (which is still included in the package).

src/wp-content/themes/twentytwelve/header.php Show resolved Hide resolved
src/wp-content/themes/twentytwelve/readme.txt Outdated Show resolved Hide resolved
src/wp-content/themes/twentytwelve/css/ie.css Outdated Show resolved Hide resolved
- Restore the html tag deleted by mistake
- Restore the credits
- Restore the deleted file
- Restore the html tag deleted by mistake
- Restore the credits
- Restore the deleted file
@metodiew
Copy link
Author

Thanks for the feedback @sabernhardt ! Applied the notes and changes, can you take a look is there anything else? if not, I'll open a new PR for the other themes, following the ticket updates. Thanks in advance!

Copy link

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you changed "Load" to "Register" in another PR, keeping a verb. Similarly, Twenty Twelve should have "Registers" for its IE stylesheet.

src/wp-content/themes/twentytwelve/functions.php Outdated Show resolved Hide resolved
src/wp-content/themes/twentytwelve/css/ie.css Outdated Show resolved Hide resolved
@metodiew metodiew requested a review from sabernhardt July 6, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants