Twenty Twenty-Three: Update Aubergine variation background #4650
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the height of the top of the background on the Aubergine variation, to hopefully improve its relative height to the page height.
I've swapped a
min()
calculation withclamp()
, to try and make the height differences more gradual and make the height slightly larger when the page content is quite short.Hopefully addresses concerns raised in WordPress/gutenberg#51248. It would be great if @anarieldesign has a chance to take a look at these changes too.
Trac ticket: https://core.trac.wordpress.org/ticket/58475
Example of changes on a page with a short height:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.