Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IE specific checks from default themes in Twenty Sixteen #4658

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

metodiew
Copy link

Remove IE specific checks from default themes in Twenty Sixteen

Trac ticket: 56699

Copy link

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the .widecolumn class period, restore the full comments, and remove the new space before .updated:not(.published).

src/wp-content/themes/twentysixteen/inc/customizer.php Outdated Show resolved Hide resolved
src/wp-content/themes/twentysixteen/inc/customizer.php Outdated Show resolved Hide resolved
src/wp-content/themes/twentysixteen/inc/customizer.php Outdated Show resolved Hide resolved
src/wp-content/themes/twentysixteen/style.css Outdated Show resolved Hide resolved
src/wp-content/themes/twentysixteen/style.css Outdated Show resolved Hide resolved
metodiew and others added 5 commits June 27, 2023 12:30
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
@metodiew metodiew requested a review from sabernhardt July 6, 2023 08:20
// Load the html5 shiv.
wp_enqueue_script( 'twentysixteen-html5', get_template_directory_uri() . '/js/html5.js', array(), '3.7.3' );
// Register the html5 shiv.
wp_register_style( 'twentysixteen-html5', get_template_directory_uri() . '/js/html5.js', array(), '3.7.3' );

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs to use wp_register_script. I missed that earlier.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, not sure how I missed that as well, updated!

@khansahan9864
Copy link

If you're working with a website or web application and want to remove conditional checks or styles specifically targeting Internet Explorer, you can follow these general steps:

Identify IE-specific code:
Look through your CSS files and HTML templates for code that is specifically targeting Internet Explorer. This might include conditional comments, IE-specific CSS rules, or JavaScript checks.

Remove conditional comments:
In older versions of HTML, conditional comments were used to target specific versions of Internet Explorer. If you find these in your code, you can safely remove them. For example:

{{{
#!html





}}}

Update CSS rules:
Look for CSS rules that are specifically written for Internet Explorer and remove them. Modern browsers usually have better support for web standards, so many of these rules may no longer be necessary.

Test in multiple browsers:
After making changes, thoroughly test your website or application in multiple browsers (Chrome, Firefox, Safari, Edge, etc.) to ensure that removing IE-specific code doesn't introduce new issues.

Consider using feature detection:
Instead of targeting specific browsers, consider using feature detection with JavaScript libraries like Modernizr. This allows you to detect browser capabilities and apply styles or functionality based on features rather than specific browser versions.

Update JavaScript checks:
If your code includes JavaScript checks for IE-specific features, you might want to update or remove them. Modern browsers have improved compatibility, reducing the need for browser-specific JavaScript code.

Check compatibility mode:
If you're working with a legacy application, make sure it's not running in compatibility mode for Internet Explorer. This mode can cause the browser to behave as an older version and may require specific code for compatibility.

Always keep in mind the importance of testing across different browsers and versions after making changes to ensure a consistent and functional user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants