New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IE specific checks from default themes in Twenty Sixteen #4658
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please restore the .widecolumn
class period, restore the full comments, and remove the new space before .updated:not(.published)
.
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
// Load the html5 shiv. | ||
wp_enqueue_script( 'twentysixteen-html5', get_template_directory_uri() . '/js/html5.js', array(), '3.7.3' ); | ||
// Register the html5 shiv. | ||
wp_register_style( 'twentysixteen-html5', get_template_directory_uri() . '/js/html5.js', array(), '3.7.3' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line needs to use wp_register_script
. I missed that earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, not sure how I missed that as well, updated!
If you're working with a website or web application and want to remove conditional checks or styles specifically targeting Internet Explorer, you can follow these general steps: Identify IE-specific code: Remove conditional comments: Update CSS rules: Test in multiple browsers: Consider using feature detection: Update JavaScript checks: Check compatibility mode: Always keep in mind the importance of testing across different browsers and versions after making changes to ensure a consistent and functional user experience. |
Remove IE specific checks from default themes in Twenty Sixteen
Trac ticket: 56699