Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try storing the E2E screenshots as artifcats when the tests fail. #4671

Closed
wants to merge 3 commits into from
Closed

Try storing the E2E screenshots as artifcats when the tests fail. #4671

wants to merge 3 commits into from

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Jun 22, 2023 •
edited

@peterwilsoncc peterwilsoncc marked this pull request as ready for review June 22, 2023 06:08
tellthemachines
tellthemachines approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterwilsoncc
Copy link
Contributor Author

Committed r55991 / 1516216

@peterwilsoncc peterwilsoncc deleted the try/e2e-store-failure-artifacts branch June 22, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tellthemachines tellthemachines tellthemachines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@peterwilsoncc @tellthemachines