Fix block editor stylesheet being registered with wrong URL #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcgill
approved these changes
Jun 22, 2023
Co-authored-by: Joe McGill <801097+joemcgill@users.noreply.github.com>
mukeshpanchal27
approved these changes
Jun 23, 2023
Comment on lines
+334
to
+335
| $metadata_file = ABSPATH . $block_json_path; | ||
| $metadata = wp_json_file_decode( $metadata_file, array( 'associative' => true ) ); |
There was a problem hiding this comment.
instead of loading the metadata like this, by not use the parsed php?
Suggested change
| $metadata_file = ABSPATH . $block_json_path; | |
| $metadata = wp_json_file_decode( $metadata_file, array( 'associative' => true ) ); | |
| $core_blocks_meta = require ABSPATH . WPINC . '/blocks/blocks-json.php'; | |
| $metadata = $core_blocks_meta[$block_name]; |
There was a problem hiding this comment.
I think for tests that doesn't really matter. The block.json file is the source of truth while blocks-json.php is a built file, so I think for tests relying on block.json is a more reliable approach.
|
Committed in https://core.trac.wordpress.org/changeset/56005. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/58605
This PR also includes test coverage for the core-specific code paths of
register_block_style_handle()which was missing before.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.