Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect newer Opera user agent strings. #4721

Closed
wants to merge 3 commits into from
Closed

Detect newer Opera user agent strings. #4721

wants to merge 3 commits into from

Conversation

costdev
Copy link
Contributor

@costdev costdev commented Jun 27, 2023 •
edited

@costdev costdev changed the title Add detection for "OPR" + move Opera above Chrome. Detect newer Opera user agent strings. Jun 27, 2023
@costdev costdev marked this pull request as ready for review June 27, 2023 16:00
mukeshpanchal27
mukeshpanchal27 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @costdev for the PR. Moving above the chrome detection make sense. LGTM!

@costdev @peterwilsoncc
Use OPR/ instead of OPR.
0377829 
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
peterwilsoncc
peterwilsoncc approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Colin.

@peterwilsoncc
Copy link
Contributor

Committed r56224 / b892f51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@costdev @peterwilsoncc @mukeshpanchal27