58645: Remove grunt-jsvalidate from build process #4724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcgill
requested changes
Jun 27, 2023
joemcgill
approved these changes
Jun 27, 2023
| @@ -1819,7 +1818,7 @@ module.exports = function(grunt) { | |||
| if ( action !== 'deleted' ) { | |||
| grunt.config( [ 'copy', 'dynamic-js', 'files' ], files ); | |||
| } | |||
| // For the webpack builds configure the jsvalidate task to only check those files build by webpack. | |||
| // For the webpack builds configure the task to only check those files built by webpack. | |||
There was a problem hiding this comment.
I'm curious now that we're removing jsvalidate if this whole else if could be removed or if it's still useful for some reason. I don't see that as a blocker to this patch though, so going to pre-approve.
There was a problem hiding this comment.
I wasn't certain so erred on the side of not changing the block, since it affects a non-validate-specific task.
|
Committed in https://core.trac.wordpress.org/changeset/56247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/58645