Rename wp_in_development_mode() to wp_is_development_mode()
#4850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to [56223] which replaces the `wp_in_` prefix with `wp_is_` to be more consistent with other boolean functions in WordPress, like wp_is_maintenance_mode(), wp_is_recovery_mode(), etc. See #57487.
SergeyBiryukov
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Good catch, thanks! wp_is_development_mode() would be my preference too.
See comment 6 on #49959 for renaming wp_in_maintenance_mode() to wp_is_maintenance_mode() previously.
joemcgill
changed the title
wp_in_development_mode() to wp_is_development_mode()wp_in_development_mode() to wp_is_development_mode() and check for 'any'
|
I've added a new commit to this PR to address @azaozz's comment in https://core.trac.wordpress.org/ticket/57487#comment:55 about the need to support checking for any valid development mode. |
felixarntz
requested changes
Jul 17, 2023
felixarntz
reviewed
Jul 17, 2023
This reverts commit 4412e41.
joemcgill
changed the title
wp_in_development_mode() to wp_is_development_mode() and check for 'any'wp_in_development_mode() to wp_is_development_mode()
felixarntz
approved these changes
Jul 17, 2023
|
I've committed the name change in https://core.trac.wordpress.org/changeset/56249. The conversation about adding a default value can continue on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to [56223] which replaces the
wp_in_prefix withwp_is_to be more consistent with other boolean functions in WordPress, like wp_is_maintenance_mode(), wp_is_recovery_mode(), etc.See #57487.
Trac ticket: https://core.trac.wordpress.org/ticket/57487
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.