Update class-wp-style-engine-processor.php

[Rajinsharwar]

Setting the default optimization option to false.

Trac ticket: https://core.trac.wordpress.org/ticket/58811

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[audrasjb]

PHP Unit tests are failing, I think they need to be modified accordingly.

[ramonjd]

Thanks for the patch.

There's a corresponding Gutenberg issue:

• Gutenberg Bug - Nested WP Element Styles Broken gutenberg#52646

I think it should be addressed there unless there's urgency in Core.

[ramonjd]

Thanks for this patch!

Here's an equivalent Gutenberg PR with tests:

WordPress/gutenberg#53085

[ramonjd]

Thank you for this PR.

I just left a couple of notes related to annotations.

[SergeyBiryukov]

Thanks for the PR! If optimize is no longer enabled by default, then a few other DocBlocks will have to be updated as well, see r55820 for all the instances that should be changed to Default false.

[Rajinsharwar]

Thanks for letting me know @SergeyBiryukov. Just updated the other DocBlocks.

[audrasjb]

This is not a correct since mention (should be something like @since 6.3.0 $optimize now defaults to false.) but I'm not sure we need a since mention at the first place.
Any thought @SergeyBiryukov?

[Rajinsharwar]

I think we should go with something like: @audrasjb

 * Optimization is no longer the default
 * @ticket 58811

[audrasjb]

Thanks for the proposal @Rajinsharwar, but this is not a correct way to use since mentions.
Please check Docblock standards: https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#since-section-changelogs

[Rajinsharwar]

Thanks for that @audrasjb, just updated it. Can you take a look?

[tellthemachines]

Committed in r56574.