Update credits.php #4909
Closed
Update credits.php #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending folks to https://make.wordpress.org/contribute for a short survey on what team they may be interested in joining. This coincides with the Get Involved tab. Please test against Multisite.
audrasjb
approved these changes
Jul 25, 2023
|
I suppose there is no localized equivalent of this URL? |
|
(and I can confirm that this will work on multisite as well) |
| @@ -60,7 +60,7 @@ | |||
| ); | |||
| ?> | |||
| <br /> | |||
| <a href="https://make.wordpress.org/"><?php _e( 'Get involved in WordPress.' ); ?></a> | |||
| <a href="https://make.wordpress.org/contribute"><?php _e( 'Get involved in WordPress.' ); ?></a> | |||
There was a problem hiding this comment.
Suggested change
| <a href="https://make.wordpress.org/contribute"><?php _e( 'Get involved in WordPress.' ); ?></a> | |
| <a href="https://make.wordpress.org/contribute/"><?php _e( 'Get involved in WordPress.' ); ?></a> |
Let's add a slash here to avoid an extra redirect 🙂
There was a problem hiding this comment.
There is also another link in line 71 that needs the same adjustment.
|
Thanks for the PR! Merged in r56311. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending folks to https://make.wordpress.org/contribute for a short survey on what team they may be interested in joining. This coincides with the Get Involved tab.
Please test against Multisite.
https://core.trac.wordpress.org/ticket/23348