New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated: Use 6th parmeter of wp_enqueue_script() and wp_register_script() #5073
Conversation
In the @nirav7707's PR, at twentytwentyone/functions.php line WordPress#424, 433 wp_register_script() missed array at 6th paramerter. Here, added this. Ticket: https://core.trac.wordpress.org/ticket/58634
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrinal013 Thank you for the updated PR! Looks good mostly, just one thing that needs to be addressed.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mrinal013, LGTM!
Committed in https://core.trac.wordpress.org/changeset/56526 |
In the previous PR, at twentytwentyone/functions.php line #424, 433 wp_register_script() missed array at 6th parameter. Here, added this.
Trac Ticket: https://core.trac.wordpress.org/ticket/58634
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.