40370-patch

[misfist]

• Applied 3 patches
• Inserted patch updates that failed
• Corrected code formatted for newly added code

---

Additional

Unit testing is required.

In manual tests, I found that an image uploaded when there are 3 image sizes with the same dimensions, but different crop settings, separate images were created for each of the images sizes.

Given the usecase:

add_image_size( 'newscentered', 400, 400, array( 'center', 'center') );
add_image_size( 'newstop', 400, 400, array( 'center', 'top' ) );
add_image_size( 'newsbottom', 400, 400, array( 'center', 'bottom' ) );

Uploaded the image carmella-red-dress.png

Produced the following files:
carmella-red-dress.png (original file)
carmella-red-dress-400x400-53fd9f7a.png
carmella-red-dress-400x400-420047e7.png
carmella-red-dress-400x400-34920233.png

Trac ticket: add_image_sizes does not create the "crop position" versions of the image

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[TimothyBJacobs]

Thanks for the PR @misfist! It looks like there are some linting issues we need to resolve.

Could you also add a description for the function parameters we are introducing?