Use wp_trigger_error() in _doing_it_wrong() and _deprecated_*() functions
#5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellofromtonya
changed the title
_deprecated_*() functions_doing_it_wrong() and _deprecated_*() functions
costdev
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Thanks for the PR @hellofromtonya! I agree that the single call to wp_trigger_error() is best here, and the changes look clean and good to go.
hellofromtonya
commented
Sep 7, 2023
src/wp-includes/functions.php
Outdated
| ); | ||
| } | ||
|
|
||
| wp_trigger_error( $function_name, $message ); |
There was a problem hiding this comment.
Whoopsie, should not be passing the function name. _doing_it_wrong() already added it to the message.
Fixed in 0293e8f ✅
|
Committed via https://core.trac.wordpress.org/changeset/56705. |
hellofromtonya
deleted the
try/use-wp_trigger_error-in-functions.php
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
wp_trigger_error()in_doing_it_wrong()and each_deprecated_*()function, i.e. instead oftrigger_error().To avoid redundancy, used
wp_trigger_error()once. How? Saved each message to$messagevariable and then passed it towp_trigger_error()at the end of the function.Trac ticket: https://core.trac.wordpress.org/ticket/57686
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.