Fix route conflicts for the auto-save and revisions endpoints of the wp_template and wp_template_part post types #5194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-vlasenko
changed the title
anton-vlasenko
force-pushed
the
fix/template-revision-autosave-endpoints
branch
from
6e20189
to
0d6ab54
Compare
|
Why register late? Why not register all post type controller like this? |
I've replied in the ticket: https://core.trac.wordpress.org/ticket/56922#comment:13 |
anton-vlasenko
commented
Sep 18, 2023
| @@ -5074,6 +5074,338 @@ mockedApiResponse.Schema = { | |||
| } | |||
| ] | |||
| }, | |||
| "/wp/v2/templates/(?P<parent>[\\d]+)/revisions": { | |||
There was a problem hiding this comment.
The changes in the wp-api-generated.js file are auto-generated, so probably it makes no sense to review them.
anton-vlasenko
force-pushed
the
fix/template-revision-autosave-endpoints
branch
2 times, most recently
from
343426f
to
e31904c
Compare
anton-vlasenko
force-pushed
the
fix/template-revision-autosave-endpoints
branch
from
e31904c
to
9f8d174
Compare
|
Closed in favor of #3533. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Fixes https://core.trac.wordpress.org/ticket/56922.
This PR addresses route conflicts between
WP_REST_Templates_Controllerand bothWP_REST_Revisions_ControllerandWP_REST_Autosaves_Controller.When making REST requests to the following endpoints:
wp/v2/templates/<parent_post_id>/revisionswp/v2/templates/<parent_post_id>/autosaveswp/v2/template-parts/<parent_post_id>/revisionswp/v2/template-parts/<parent_post_id>/autosavesthe
WP_REST_Templates_Controller::get_item()method is incorrectly matched as the callback method to process these requests. This misidentification arises from the regular expression that defines the problematic route in theWP_REST_Templates_Controllerclass, specifically:/(?P<id>([^\/:<>\*\?"\|]+(?:\/[^\/:<>\*\?"\|]+)?)[\/\w%-]+).In actuality, the aforementioned requests should be handled by the
WP_REST_Revisions_Controller::get_items()andWP_REST_Autosaves_Controller::get_items()callbacks, depending on whether it's arevisionsorautosavesrequest.How
This PR modifies the order in which the routes for endpoints in
WP_REST_Templates_Controller,WP_REST_Revisions_Controller, andWP_REST_Autosaves_Controllerare registered.Routes in
WP_REST_Revisions_ControllerandWP_REST_Autosaves_Controllerare now registered prior to those inWP_REST_Templates_Controller.This ensures the correct callback is matched, preventing
WP_REST_Templates_Controller::get_item()from being mistakenly matched for the endpoints listed above.However, this change is limited to the
wp_templateandwp_template_partspost types to mitigate the risk of introducing new bugs.