Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administration: Use wp_admin_notice() in /wp-admin/includes/. #5224

Conversation

costdev
Copy link
Contributor

@costdev costdev commented Sep 15, 2023

Adds further usages of wp_admin_notice() in the root level of /wp-admin/includes/ on
.notice-error, .notice-warning, .error, and .updated.

Ongoing task to implement new function across core.

Trac ticket: https://core.trac.wordpress.org/ticket/57791

@costdev costdev changed the title Implement wp admin notice in wp admin includes Administration: Use wp_admin_notice() in /wp-admin/includes/. Sep 15, 2023
@costdev costdev marked this pull request as ready for review September 15, 2023 19:02
@costdev costdev force-pushed the implement_wp_admin_notice_in_wp-admin_includes branch 2 times, most recently from 11a0bd9 to 57aff63 Compare September 15, 2023 19:33
@costdev costdev force-pushed the implement_wp_admin_notice_in_wp-admin_includes branch from 57aff63 to 591231e Compare September 15, 2023 20:04
Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a lot to change. Looks pretty good!

src/wp-admin/includes/dashboard.php Show resolved Hide resolved
src/wp-admin/includes/network.php Show resolved Hide resolved
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @costdev, The changes look good to me.

@mukeshpanchal27
Copy link
Member

Screenshot 2023-09-17 at 7 54 36 PM

Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joedolson
Copy link
Contributor

In r56599

@joedolson joedolson closed this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants