Build/Test Tools: Add sys_get_temp_dir() to open_basedir tests.
#5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costdev
force-pushed
the
add_sys_temp_dir_to_open_basedir
branch
from
fcca8ba
to
37e4e57
Compare
costdev
force-pushed
the
add_sys_temp_dir_to_open_basedir
branch
from
37e4e57
to
a9f4f23
Compare
SergeyBiryukov
approved these changes
Sep 19, 2023
|
Committed in r56622. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHPUnit 9.6.13, the child processes used for process isolation now use temporary files to communicate their result to the parent process. This caused a failure in some tests that set the
open_basedirPHP directive.This adds
sys_get_temp_dir()to theopen_basedirvalue set by the tests.References:
Trac ticket: https://core.trac.wordpress.org/ticket/59394