Use _prime_post_caches if the query is not filtered.
#5251
Conversation
There was a problem hiding this comment.
@spacedmonkey Only one crucial point of feedback here, similar to what I mentioned on the original PR.
Other than that, this looks good to me.
src/wp-includes/class-wp-query.php
Outdated
| @@ -3270,10 +3270,11 @@ public function get_posts() { | |||
| return $post_parents; | |||
| } | |||
|
|
|||
| $unfiltered_query = $old_request == $this->request && "{$wpdb->posts}.*" === $fields; | |||
There was a problem hiding this comment.
Two things:
- Why a non-strict comparison here? Can't we use
===? - Nit-pick, but maybe
$is_unfiltered_queryis a better name here, to clarify that this is a boolean.
There was a problem hiding this comment.
I have changed the variable name. But I will not change the logic for now. That is the logic it was before and I don't want to change it.
There was a problem hiding this comment.
@spacedmonkey Why not use ===? I see this was using == before, but I don't think there's a good reason not to fix it. The request is always a string, and I don't think for strings the == or === even makes a real difference. I think we should use === in accordance with the latest WordPress coding standards and using strict comparisons.
There was a problem hiding this comment.
Thanks @spacedmonkey for the updates, LGTM. I'd still recommend using a strict comparison in #5251 (comment), but not a blocker.
Would be great to get @peterwilsoncc's review on this as well before committing.
|
Committed e486ac0 |
Trac ticket: https://core.trac.wordpress.org/ticket/58599
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.