Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: mention reusable block rename to pattern(s) in each doc #5286

Closed

Conversation

benjaminknox
Copy link

@benjaminknox benjaminknox commented Sep 23, 2023

This adds comments in the docs that patterns and reusable blocks are the same, and that patterns is the new name since 6.3.0.

Trac ticket: https://core.trac.wordpress.org/ticket/59388


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@benjaminknox benjaminknox force-pushed the bpk/update-comments-patterns branch 3 times, most recently from 57762ed to 523eee4 Compare September 23, 2023 01:50
Copy link
Member

@marybaum marybaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we had time, I would make some copy changes for clarity in line 71 of about.php, but this is not the time. So, officially, LGTM

@benjaminknox
Copy link
Author

If we had time, I would make some copy changes for clarity in line 71 of about.php, but this is not the time. So, officially, LGTM

@marybaum What changes would you make? I don't mind opening it in another PR if you want

@marybaum
Copy link
Member

marybaum commented Oct 16, 2023

Two things:

  1. I would change the phrase 'previously referred to as reusable blocks' to 'formerly reusable blocks' or 'formerly called reusable blocks'

  2. I would change this —

'WordPress 6.3 brings your content, templates, and patterns together in the Site Editor for the first time. Add pages, browse style variations, create synced patterns (previously referred to as “reusable blocks”), and enjoy fine-tuned control over your navigation menus. No more time wasted switching across different site areas—now you can focus on what matters most. Creation to completion, all in one place.' )

to this —

'For the first time ever, WordPress 6.4* pulls all your tools together. Because now your content, templates, and patterns live in the Site Editor, at your fingertips, ready to help you add pages, consider style variations, build synced patterns (what you used to call 'reusable blocks')' and fine-tune your menus. Starting right now, never spend another second switching from one part of your site to another. Instead, focus on what matters most: concept to complete, in one fluid process, in one convenient place.'

*Definitely change this to the current release. 6.3 has been out a while ...

Nothing like pumping extra drama into copy so people can see themselves as the star of the show! Also, we don't need to say 'navigation menus'—one word implies the other. Use as much or as little of this as you like!

@benjaminknox benjaminknox force-pushed the bpk/update-comments-patterns branch 3 times, most recently from cf636be to 16b4af7 Compare October 17, 2023 15:51
@benjaminknox
Copy link
Author

I would change the phrase 'previously referred to as reusable blocks' to 'formerly reusable blocks' or 'formerly called reusable blocks'

@marybaum I took your suggestion and updated the comments through the PR to read 'formerly called reusable blocks'

@hellofromtonya How does this look?

Copy link
Member

@SergeyBiryukov SergeyBiryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments where “patterns” (plural) seems more appropriate than “pattern”.

src/wp-includes/blocks.php Outdated Show resolved Hide resolved
tests/phpunit/tests/rest-api/rest-blocks-controller.php Outdated Show resolved Hide resolved
@SergeyBiryukov
Copy link
Member

Thanks for the PR! I think we can keep the "(formerly called reusable blocks)" wording in some top-level DocBlocks, but inline comments and unit tests can just use the new name directly.

Merged in r57032 with some adjustments to avoid redundancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants