Fix notice error in php unit tests. #5320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
force-pushed
the
fix/no-real
branch
from
c5114c0
to
a6a2f3d
Compare
spacedmonkey
changed the title
westonruter
reviewed
Sep 27, 2023
| @@ -181,7 +181,7 @@ function register_block_script_handle( $metadata, $field_name, $index = 0 ) { | |||
| $script_uri = get_block_asset_url( $script_path_norm ); | |||
|
|
|||
| $script_args = array(); | |||
| if ( 'viewScript' === $field_name ) { | |||
| if ( 'viewScript' === $field_name && $script_uri ) { | |||
There was a problem hiding this comment.
This works too. But it's just that it's not ideal from a code coverage perspective, since the in normal execution the condition would be truthy. It's just that during PHPUnit tests that it is false. So this is essentially adding a condition like ! $is_running_unit_tests
There was a problem hiding this comment.
@westonruter This is a valid case to catch outside of unit tests. If you pass an empty thing as a path to script, this should result false. For example, if you using a unbuilt version of plugin for development this might happen.
There was a problem hiding this comment.
Does this solve https://core.trac.wordpress.org/ticket/59475?
westonruter
approved these changes
Sep 27, 2023
spacedmonkey
requested review from
gziolo,
joemcgill,
felixarntz and
mukeshpanchal27
mukeshpanchal27
approved these changes
Sep 28, 2023
|
Committed in 345fb48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/59475
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.