Fix custom button block style so that its path is correctly provided #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
reviewed
Sep 27, 2023
| @@ -3154,6 +3154,7 @@ function wp_enqueue_stored_styles( $options = array() ) { | |||
| * @type string[] $deps Array of registered stylesheet handles this stylesheet depends on. | |||
| * @type string|bool|null $ver Stylesheet version number. | |||
| * @type string $media The media for which this stylesheet has been defined. | |||
| * @type string|null $path Absolute path to the stylesheet, so that it can potentially be inlined. | |||
There was a problem hiding this comment.
Should 'path' => null be added to the default args below?
There was a problem hiding this comment.
Not sure if this is needed.
|
@felixarntz I think the TT4 fix this needs to be fixed upstream in the TT4 repo as development is happening there https://github.com/WordPress/twentytwentyfour. |
|
Closing in favor of https://core.trac.wordpress.org/changeset/56754 and WordPress/twentytwentyfour#545. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'path'argument ofwp_enqueue_block_style()needs to be used instead ofwp_style_add_data(). The latter only works when usingwp_register_style()orwp_enqueue_style().get_theme_file_uri()andget_theme_file_path(), so that they can be optionally overwritten in a child theme.wp_enqueue_block_style()function has its documentation improved to add the missing parameter.Trac ticket: https://core.trac.wordpress.org/ticket/59466
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.