Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML API: Only pass a single class name to add_class() #5325

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

HTML API: Only pass a single class name to add_class() #5325

wants to merge 1 commit into from
+79 −47

Commits on Sep 27, 2023

  1. HTML API: Only pass a single class name to add_class() 

    In some places, multiple classes are being passed to the Tag Processor's
`add_class()` method. They are being passed as a string containing class
names separated by whitespace. This produces the expected behavior because
the Tag Processor doesn't enforce its expectation in the `add_class()`
method, but allowing this can lead to mistakes when interacting with
classes.

In this patch these places are updated to only add a single class at a
time, and a helper CSS class is created with a commonly-used method
`class_list()` to split such combined strings.
    @dmsnell
    dmsnell committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    6820bd1 View commit details
    Browse the repository at this point in the history