Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New filter admin_canonical_url #5412

Closed
wants to merge 3 commits into from
Closed

Conversation

prionkor
Copy link

@prionkor prionkor commented Oct 5, 2023

Trac ticket:

https://core.trac.wordpress.org/ticket/59545

Related PR #1504

Trac ticket:


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! It looks good to me, I added some change requests ;)

src/wp-admin/includes/misc.php Outdated Show resolved Hide resolved
src/wp-admin/includes/misc.php Outdated Show resolved Hide resolved
@prionkor
Copy link
Author

prionkor commented Oct 5, 2023

The failed test is timeout and not relevant to the change. What is the next step?

@audrasjb
Copy link
Contributor

audrasjb commented Oct 5, 2023

The failed test is timeout and not relevant to the change. What is the next step?

No worries, it clearly appears that it is a timeout, so this is not a blocker.

@audrasjb
Copy link
Contributor

@audrasjb audrasjb closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants