Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the parameters name in WP_Block_List class to be consistent with ArrayAccess interface #5425

Closed

Conversation

Rahmon
Copy link

@Rahmon Rahmon commented Oct 7, 2023

This PR updates the parameter names in the WP_Block_List class to follow the same defined in the ArrayAccess interface.

Trac ticket: https://core.trac.wordpress.org/ticket/58976


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r56803.

@Rahmon Rahmon deleted the fix/signatures-methods-in-child-classes branch October 9, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants