Prime parent cache on save post. #5443
Conversation
| * This function sets or updates the post parent cache for a given post ID. | ||
| * The post parent cache is used to store the parent ID of a post for quick retrieval. | ||
| * | ||
| * @since 6.4.0 |
There was a problem hiding this comment.
| * @since 6.4.0 | |
| * @since 6.4.0 |
| * The post parent cache is used to store the parent ID of a post for quick retrieval. | ||
| * | ||
| * @since 6.4.0 | ||
| * |
There was a problem hiding this comment.
| * | |
| * @access private | |
| * |
| * @param int $post_id The ID of the post for which to set or update the parent cache. | ||
| * @param WP_Post $post The post object representing the post. |
There was a problem hiding this comment.
| * @param int $post_id The ID of the post for which to set or update the parent cache. | |
| * @param WP_Post $post The post object representing the post. | |
| * @param int $post_id The ID of the post for which to set or update the parent cache. | |
| * @param WP_Post $post The post object representing the post. |
| @@ -3568,6 +3568,21 @@ function _reset_front_page_settings_for_post( $post_id ) { | |||
| unstick_post( $post->ID ); | |||
| } | |||
|
|
|||
| /** | |||
| * Set or update the post parent cache for a specific post. | |||
There was a problem hiding this comment.
| * Set or update the post parent cache for a specific post. | |
| * Sets or updates the post parent cache for a specific post. |
There was a problem hiding this comment.
Thanks for working on this @spacedmonkey, and sorry for the delay in reviewing it. The approach looks solid, but personally, I don't see a lot of value in this, unless I'm missing something. Given that for most sites the cache will be non-persistent, these primed caches will never be used.
For sites that do have a persistent cache, this DB query would be more efficiently called when reading versus when writing data, where it would only be in the cache when some query is requesting it—and then, only the first time. Plus, when IDs are cached in queries, multiple IDs could be cached at the same time, rather that one at a time here.
If we decide to do this later, we can revisit as part of a standalone follow-up ticket.
Break out from #5420.
Trac ticket: https://core.trac.wordpress.org/ticket/59188
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.