Block: Give traverse_and_serialize_block(s)' post-callback access to block instance
#5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
changed the title
traverse_and_serialize_block(s)' post-callback access to block instance
8 tasks
gziolo
approved these changes
Oct 18, 2023
|
Committed to Core |
ockham
deleted the
update/traverse-and-serialize-blocks-give-post-callback-access-to-block
branch
|
Backported to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the
$pre_and$post_callbackfunctions that are given as arguments totraverse_and_serialize_block(s)receive a reference to the current block as its first argument. However, while any changes that the "pre" callback makes to the block are actually respected during serialization, the same isn't true for the "post" callback: Any changes that it makes are only applied after the block has already been serialized. For applications like#59412, we probably want to change that.Testing instructions
The behavior is covered by the newly added unit test. You can verify that it fails on
trunkby cherry-picking a8c6633 there, and runningnpm run test:php -- --group=blocks.Trac ticket: https://core.trac.wordpress.org/ticket/59669
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.