Clear stylesheet and template cache when switching sites #5532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This nulls the global `wp_template_path` and `wp_stylesheet_path` data whenever a site is switched or restored so that the next call to `get_stylesheet_directory()` or `get_template_directory()` will provide fresh data. See https://core.trac.wordpress.org/ticket/59677
felixarntz
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
@jeremyfelt This solution looks great, including the tests!
Only minor nit-pick feedback on test skipping and test annotations per recent conventions.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
costdev
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Thanks @jeremyfelt! The solution looks good to me too, I just see a couple of minor docs updates to do. Pre-approving as I'm currently on vacation and unlikely to get a chance to review again before this is committed.
props costdev
|
Committed in https://core.trac.wordpress.org/changeset/56974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This nulls the global
wp_template_pathandwp_stylesheet_pathdata whenever a site is switched or restored so that the next call toget_stylesheet_directory()orget_template_directory()will provide fresh data.See https://core.trac.wordpress.org/ticket/59677
Trac ticket: https://core.trac.wordpress.org/ticket/59677
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.