fix: rest_pre_serve_request
needs to run after `rest_send_nocache_h…
#5564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rest_send_nocache_headers
block was moved afterrest_pre_serve_request
in WordPress/WordPress@3f1e6a6.This renders
rest_pre_serve_request
useless becauserest_send_nocache_headers
sends / removes http headers. As a result, usingrest_pre_serve_request
for it's intended purpose (to manually send the request) results in:Cannot modify header information - headers already sent.
Suggest moving the
rest_send_nocache_headers
block before therest_pre_serve_request
filter.Trac ticket: https://core.trac.wordpress.org/ticket/59722#ticket
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.